Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more command: continue, step, ... #62

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

yurydelendik
Copy link
Contributor

Add support for:

  • qProcessInfo
  • qRegisterInfo
  • qSymbol
  • c -- continue
  • s -- step

Extends support for 'H' -- supports different targets.

@jD91mZM2
Copy link
Collaborator

The c/s/whatever packets are deprecated, see the wiki

@jD91mZM2
Copy link
Collaborator

Speaking of which, I can't find qProcessInfo and qRegisterInfo in the wiki? Are these custom query packets, that should potentially be generalized?

@yurydelendik
Copy link
Contributor Author

Just to add context, I'm working on implementing command that are used in V8 to support Wasm debugging. See e.g. https://github.com/kishiguro/chromium_v8/blob/5d8f3b46a570b25e27c492e86455072012601f90/src/debug/wasm/gdb-server/target.cc (and my implementation at https://github.com/yurydelendik/rust-gdb-remote-protocol/tree/wasm)

The c/s/whatever packets are deprecated,

I can place all deprecated commands under a feature flag

I can't find qProcessInfo and qRegisterInfo in the wiki

They perhaps coming from LLDB extension, e.g. https://opensource.apple.com/source/lldb/lldb-310.2.36/docs/lldb-gdb-remote.txt.auto.html

@jD91mZM2
Copy link
Collaborator

I can place all deprecated commands under a feature flag

Please do, thank you :)

Let me know when you're done, and I'll merge this PR - it looks good!

They perhaps coming from LLDB extension, e.g. https://opensource.apple.com/source/lldb/lldb-310.2.36/docs/lldb-gdb-remote.txt.auto.html

Ah, that's it, thanks!

@tromey
Copy link
Collaborator

tromey commented Aug 24, 2020

The c/s/whatever packets are deprecated, see the wiki

FWIW they are only really deprecated if the remote supporst vCont -- but for a single-threaded remote, it's reasonable to not support it and to implement the older style. Some stubs try to optimize for size and only handle a minimal number of packets -- though I'm not sure if rust-gdb-remote-protocol intends to ever support this mode.

See #26 for some info on the difficulties of vCont along with non-stop. This may touch on this PR -- namely, should callbacks that run the inferior be synchronous or not.

@yurydelendik
Copy link
Contributor Author

Not really sure how to use cfg() with nom macros -- added separate parser-functions

@yurydelendik
Copy link
Contributor Author

Let me know when you're done, and I'll merge this PR - it looks good!

@jD91mZM2 I think it is all set for this PR.

@jD91mZM2
Copy link
Collaborator

jD91mZM2 commented Sep 3, 2020

Sorry for the delay!

@jD91mZM2 jD91mZM2 merged commit 1e14865 into luser:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants